gh-137942: urllib2 with proxy tests maybe fail on macOS #137943
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All commit authors signed the Contributor License Agreement. |
This comment was marked as resolved.
This comment was marked as resolved.
Signed-off-by: yihong0618 <[email protected]>
Signed-off-by: yihong0618 <[email protected]>
yihong0618
force-pushed
the
hy/close_issue_137942
branch
from
7f5c323 to
6516250
Compare
|
!buildbot macos |
|
🤖 New build scheduled with the buildbot fleet by @ZeroIntensity for commit dd02380 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F137943%2Fmerge The command will test the builders whose names match following regular expression: The builders matched are:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even though the test code sets NO_PROXY='' and no_proxy='' in ProxyAuthTests.setUp(), since the HTTP_PROXY environment variable is not set, getproxies_environment() returns an empty dictionary.
the proxy_bypass function falls back to using the macOS system configuration (proxy_bypass_macosx_sysconf).
maybe for the macOS system settings,
localhost is bypassed from the proxy, which causes the direct connection to fail.
test_urllib2_localneton macOS #137942